Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frame buffer not being recycled issue #64

Open
andy840119 opened this issue Oct 6, 2021 · 5 comments
Open

Fix frame buffer not being recycled issue #64

andy840119 opened this issue Oct 6, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@andy840119
Copy link
Member

image
Should check the state the will recycle buffer frame (Ctrl+F3)
@andy840119 andy840119 added the bug Something isn't working label Oct 6, 2021
@andy840119
Copy link
Member Author

image
And it will cause lots of resources on rendering.

@andy840119
Copy link
Member Author

andy840119 commented Oct 6, 2021 •
edited
Loading

Also, have the issue that the frame buffer does not being recycled.

image
See the frame buffer amount in osu.

@andy840119
Copy link
Member Author

andy840119 commented Oct 6, 2021 •
edited
Loading

image
image

And notice that might have some duplicated frame buffer.
WIll have extra 3 frame buffers if apply a CRT shader in karaoke sprite text.

@andy840119 andy840119 changed the title Fix lots of VRAM use issue Fix frame buffer not being recycled issue Oct 6, 2021
@andy840119
Copy link
Member Author

andy840119 commented Oct 6, 2021 •
edited
Loading

Also got no idea why ApplyState runs three times with the same state.

[update]: it's caused by osu-framework.

@andy840119 andy840119 mentioned this issue Oct 11, 2021
Merged
@andy840119
Copy link
Member Author

Should test this package first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119