Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the case that might let position text cannot get the position. #202

Open
andy840119 opened this issue May 21, 2022 · 2 comments
Open
Labels
bug Something isn't working

Comments

@andy840119
Copy link
Member

andy840119 commented May 21, 2022

Fix the case that might let position text cannot get the position:

  • has no main text.
  • text in the position text is null or empty.
  • start and end index is out of range.
  • end index is larger than start index.
  • text with ...

How to fix that:

  • Move GetFixedPositionText into PositionTextFormatter.
  • GetFixedPositionTexts should only fix the duplicated value and move it inside applyPositionTextToBuilder.

Where to add the test:

  • maybe TestSceneLyricSpriteTextCharacterPosition -> rename is required
@andy840119 andy840119 added the bug Something isn't working label May 21, 2022
@andy840119
Copy link
Member Author

Found while implementing #203

@andy840119
Copy link
Member Author

Also, TestSceneLyricSpriteTextCharacterPosition should be more focus on the showing the sizing of every char.
.
Should create another test case for checking if text or position has been generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant