Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should shoot an alert if no microphone permission. #562

Open
andy840119 opened this issue Apr 16, 2021 · 5 comments
Open

Should shoot an alert if no microphone permission. #562

andy840119 opened this issue Apr 16, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@andy840119
Copy link
Member

andy840119 commented Apr 16, 2021

image
Got this shit while opening the microphone on this device(on the karaoke config page.)
Should wrap a try-catch outside and shoot and alert to notification if not support microphone.
.
Also should make NotSupportMicrophoneNotification : SimpleNotification into a common class.

@andy840119 andy840119 added the bug Something isn't working label Apr 16, 2021
@andy840119
Copy link
Member Author

Note : should check is that package has something like "NoPremissionException"?

@andy840119
Copy link
Member Author

Note:
This notification will be used in

  • change(and test) microphone device.
  • pitch adjustment.

@andy840119
Copy link
Member Author

Also got index out of range in osx.
Issue is reported in framework layer.
karaoke-dev/osu-framework-microphone#43

@andy840119
Copy link
Member Author

So should have those alerts:

  • permission declined.
  • initialize error.
  • real-time error.

Also should think about how to show real-time error because it will cause many times while using.

@andy840119
Copy link
Member Author

It only happens in osx.
So priority not so high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant