Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade NUnit to 4.0 #2150

Open
2 tasks
andy840119 opened this issue Nov 29, 2023 · 2 comments
Open
2 tasks

Upgrade NUnit to 4.0 #2150

andy840119 opened this issue Nov 29, 2023 · 2 comments
Labels
Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion.

Comments

@andy840119
Copy link
Member

image

Will have lots of api breaking change after upgrade to nunit 4.0
Some methods moved to LegacyAssert.

see:
https://docs.nunit.org/articles/nunit/release-notes/breaking-changes.html#nunit-40

Before start upgrade the nunit, maybe should finish at least one:

  • Wait until osu project upgrade first (?)
  • Understand why nunit make such changes.
@andy840119 andy840119 added the Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion. label Nov 29, 2023
@andy840119
Copy link
Member Author

andy840119 commented Nov 29, 2023 •
edited
Loading

Maybe we should use Assert.That(value, condition) instead?

see:
nunit/nunit#2437

@andy840119
Copy link
Member Author

And note that upgrade might have lots of similar breaking changes.
Maybe it's time to try Grit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119