New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to check if the index in the caret position is valid in the ctor. #2101

Open

andy840119 opened this issue Aug 18, 2023 · 1 comment

Labels

code quality enhancement Good for contributor

Member

andy840119 commented Aug 18, 2023 •

edited

Loading

For example, here's the TimeTagCaretPosition.
Need to :

Check if TimeTag is in the Lyric
Also, add valid index and invalid index check in the shared test case.
CompareTo should check the index of time-tag in the lyric, not compared by index.

The text was updated successfully, but these errors were encountered:

andy840119 added the enhancement label

andy840119 added this to the 2023.0909 milestone

andy840119 added the code quality label

Member Author

andy840119 commented Aug 27, 2023

[Update]

The change index out of range logic is already in the CaretPositionAlgorithm.PositionMovable().
It might be possible to give the caret position in the caret position algorithm. Using try-catch in the algorithm is not a good idea.
check the check-caret-index-is-valid-in-caret-position in my repo.

andy840119 added the Good for contributor label

andy840119 removed this from the 2023.0909 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment