Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should throw the exception if object is referenced by another property in the change handler. #2058

Open
andy840119 opened this issue Jul 5, 2023 · 1 comment
Labels
editor Karaoke ruleset's editor area

Comments

@andy840119
Copy link
Member

andy840119 commented Jul 5, 2023

If want to delete the singer:

  1. need to remove the singer id from the lyric first.
  2. remove the singer and remove all related ids from the lyric
  3. delete the singer, and clear the singer id at save the beatmap to the json.

If we select the behavior 1, need to make sure that should not delete the singer if singer is referenced by other lyric in the change handler.

Need to implement the #2056 first for able to find all reference object.

@andy840119 andy840119 added the editor Karaoke ruleset's editor area label Jul 5, 2023
@andy840119
Copy link
Member Author

andy840119 commented Jul 5, 2023

Note that we need to manually remove the singer id from the lyric.
See the BeatmapSingersChangeHandler.Remove()

Maybe we can write the utils to remove the id from the object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Karaoke ruleset's editor area
Projects
None yet
Development

No branches or pull requests

1 participant