Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sv-handle-disable is evaluated on the incorrect element. #131

Open
jkutianski opened this issue Mar 10, 2018 · 2 comments
Open

sv-handle-disable is evaluated on the incorrect element. #131

jkutianski opened this issue Mar 10, 2018 · 2 comments

Comments

@jkutianski
Copy link

If you've a custom handle, with multiple childs on it, e.target can be any of the child but not necessary the one withsv-handle or sv-handle-disabled.

@Fedik
Copy link

Fedik commented Mar 23, 2019

the fix:

var svHandleDisabled = $attrs.svHandleDisabled ? $parse($attrs.svHandleDisabled)($scope) : false;
if (svHandleDisabled) return;

@shennero
Copy link

@Fedik that fix didn't work for me but it led me to what did:

//replace                     
var svHandleDisabledAttr = e.target.attributes['sv-handle-disabled'];
//with
var svHandleDisabledAttr = e.currentTarget.attributes['sv-handle-disabled'];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants