Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize, TypeScript support, add tests #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Modernize, TypeScript support, add tests #29

wants to merge 8 commits into from

Conversation

Theaninova
Copy link

This PR adds the following

  • Rewrite in TypeScript, the JS version was used as the base but I've done tons of code splitting and rewriting to make the code base more readable
  • Test coverage for the public API
  • Bundling
    • ESM version
    • CJS version
    • Browser bundle with & without Pako

This is meant to enhance kaitai-io/kaitai_struct_compiler#249

@danaragao
Copy link

This is very useful. Any chance that this could be evaluated and merged @generalmimon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Theaninova @danaragao