Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bailout when secure boot is not enabled for UKI images is very dirty #2585

Closed
antongisli opened this issue May 23, 2024 · 4 comments · Fixed by kairos-io/immucore#326
Closed
Assignees
Labels
bug Something isn't working lane/ux triage Add this label to issues that should be triaged and prioretized in the next planning call

Comments

@antongisli
Copy link
Contributor

antongisli commented May 23, 2024

Kairos version:
3.0.x

Describe the bug
the error messages shown during boot are very raw. the program should not crash and it should not dump stack trace to console. It shoudl detect that secure boot is not enabled cleanly, inform the user, and then clean up properly/abort boot process.
image

To Reproduce
disable secure boot on a machine running TB and boot it

Expected behavior
Very tidy error message describing the reason why teh boot failed, then either stay at the console or shutdown (not sure which is best). No crashed program and no stacktrace, error should be handled gracefully.

@antongisli antongisli added bug Something isn't working triage Add this label to issues that should be triaged and prioretized in the next planning call unconfirmed labels May 23, 2024
@ci-robbot ci-robbot added the question Further information is requested label May 23, 2024
@ci-robbot
Copy link
Collaborator

Hello antongisli, thank you for reporting the issue in the kairos repository. I am an experimental bot, assisting in ticket auditing and labeling based on the requirements set by the project maintainers.

Your issue description and steps to reproduce are clear, but the required information about the Kairos version being used is missing. To ensure this issue is properly addressed, please mention the version of Kairos you are using.

Once you provide the version information, I will be able to triage the issue further. Please update the issue with the requested information, and the others involved will be able to provide solutions or further guidance. Thank you for your understanding, and again, I am here to help with auditing and labeling. I am an experiment by @mudler and @jimmykarily.

@jimmykarily jimmykarily added lane/ux and removed triage Add this label to issues that should be triaged and prioretized in the next planning call labels May 27, 2024
@jimmykarily
Copy link
Contributor

When booting is aborted an ugly message will be printed anyway. One way that was suggested during planning to avoid the message is to "sleep" forever after printing the message.

@Itxaka
Copy link
Member

Itxaka commented May 28, 2024

we like them dirty :P

@Itxaka Itxaka self-assigned this May 28, 2024
@Itxaka Itxaka removed unconfirmed question Further information is requested labels May 28, 2024
@ci-robbot ci-robbot added the triage Add this label to issues that should be triaged and prioretized in the next planning call label May 29, 2024
@ci-robbot
Copy link
Collaborator

I added the 'triage' label to your issue because it is missing some information. Please provide more details about the problem you're experiencing, such as steps to reproduce it and the versions of the artifacts you're using. This will help me to better understand and answer your question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lane/ux triage Add this label to issues that should be triaged and prioretized in the next planning call
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants