Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Sketch file cannot generate valid folder structure. #98

Open
synthresin opened this issue May 3, 2018 · 2 comments
Open

Generated Sketch file cannot generate valid folder structure. #98

synthresin opened this issue May 3, 2018 · 2 comments

Comments

@synthresin
Copy link

synthresin commented May 3, 2018

Description

Folder > Sketch generation process works fine.
Sketch > Folder export process makes invalid folder.

Version

  • Kactus: 0.3.6
  • Operating system: 10.13.4

Steps to Reproduce

  1. Generate Watcha 4.0 iOS Sketch file from Watcha 4.0 iOS folder. (It can be opened by Sketch without any issue.)
  2. remove Watcha 4.0 iOS folder
  3. regenerate folder from generated Watcha 4.0 iOS sketch file.
  4. find the folder broken (missing document.json)

Expected Behavior

Generated folder from the Sketch file shouldn't be broken.

Actual Behavior

It's broken.

Additional Information

I've shared the repo.
the branch is report/20180503

Logs

2018-05-03.kactus.production.log

@synthresin
Copy link
Author

Seems fine when I completely remove the folder from repository and commit, then regenerate new folder from the file(modified in Sketch 50).

@synthresin
Copy link
Author

synthresin commented May 10, 2018

I'll report if I get similar error again even though I keep matching sketch version across the team.

But I think there should be some way to notify JSON side effect generated by sketch version upgrade in Kactus. I don't know if it can be solved from Kactus side alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant