-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Wunderground via System Tray always uses "light" system-icons #86
Comments
The "Refresh weather" icon is also dark, but all other icons accurately follow the "light" icons. |
Thanks for opening an issue! The system tray effect should be fixed in 3.3.1! Updating should fix it. As for the refresh icon, I can set it to use the theme color! Changes coming soon. |
Unfortunately the tray icon still shows dark. Edit: "Use System Icons"->Checked, tried "Apply system colors to icons" checked and unchecked, no change. |
Weird, does the "Weather Details" page still have the block for the wind direction too as it showed in the image above? |
Yes, though it's orientation is different of course. |
Sorry the images are so large, 4K display. |
I thought these icons looked familiar. Someone brought up this issue with #80. The fix for that involved changing the icons sizes to ones where papirus provided themable icons. Papirus doesn't provide themable icons for all sizes. Try uninstalling the widget and reinstalling 3.3.1. It looks like your version hasn't gotten all the changes. |
Which icons in particular should I check out? I know a lot of them are SVG, so it shouldn't matter what size? Edit: Here's a fun one. If I turn off system icon theming every icon ends up looking normal and light as it should be. The wind direction shows a circle though (normal?). Icon in the tray ends up too small though, doesn't match the rest of the tray. Changing the details icon size did nothing (with/without system icons), changed nothing anywhere (selecting in the combobox also never enables the "save" button). |
Edit: I looked at the icons from Papirus and
Unfortunately it's missing a few but these are SVGs from Papirus, symbolics. |
At this point: System icons = correct size but wrong color, without system icons = wrong size but correct color. Details icon size changes nothing. |
The details icon size box auto-applies so it's expected that it wouldn't prompt an apply. But, it should still actually change the size of the icons. For the details screen, the widget now uses the custom bundled icons for the wind display. So a circle for 0-2kts of wind is the standard wind barb. That should show up regardless of whether use system icons is checked. So, a block showing up for the wind is an error on its own. Thanks for bringing this to my attention. I will have to look more in depth tomorrow. |
Describe the bug
Wunderground via System Tray always uses "light" system-icons when enabled.
To Reproduce
I switched from using Wundeground as a panel Widget to using the System Tray and I've noticed the tray icon itself always uses a light-theme icon if system-icons is on instead of using a dark-theme icon (like the rest of my system icons). Meanwhile the icons in Wunderground are correct.
Desktop (output of `plasmashell --version):
plasmashell 6.1.5
Screenshot (Attachment)
The text was updated successfully, but these errors were encountered: