Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wunderground via System Tray always uses "light" system-icons #86

Open
OdinVex opened this issue Nov 12, 2024 · 13 comments
Open

[Bug] Wunderground via System Tray always uses "light" system-icons #86

OdinVex opened this issue Nov 12, 2024 · 13 comments
Labels
bug Something isn't working

Comments

@OdinVex
Copy link

OdinVex commented Nov 12, 2024

Describe the bug
Wunderground via System Tray always uses "light" system-icons when enabled.

To Reproduce
I switched from using Wundeground as a panel Widget to using the System Tray and I've noticed the tray icon itself always uses a light-theme icon if system-icons is on instead of using a dark-theme icon (like the rest of my system icons). Meanwhile the icons in Wunderground are correct.

Desktop (output of `plasmashell --version):
plasmashell 6.1.5

Screenshot (Attachment)
Wunderground Tray Icon

@OdinVex OdinVex added the bug Something isn't working label Nov 12, 2024
@OdinVex
Copy link
Author

OdinVex commented Nov 13, 2024

The "Refresh weather" icon is also dark, but all other icons accurately follow the "light" icons.

@k-donn
Copy link
Owner

k-donn commented Nov 14, 2024

Thanks for opening an issue!

The system tray effect should be fixed in 3.3.1! Updating should fix it.

As for the refresh icon, I can set it to use the theme color! Changes coming soon.

@OdinVex
Copy link
Author

OdinVex commented Nov 14, 2024

Unfortunately the tray icon still shows dark.

Edit: "Use System Icons"->Checked, tried "Apply system colors to icons" checked and unchecked, no change.

@k-donn
Copy link
Owner

k-donn commented Nov 14, 2024

Weird, does the "Weather Details" page still have the block for the wind direction too as it showed in the image above?

@OdinVex
Copy link
Author

OdinVex commented Nov 14, 2024

Yes, though it's orientation is different of course.

@OdinVex
Copy link
Author

OdinVex commented Nov 14, 2024

I've forgotten to mention, this has always been a thing too (see icons):
Wunderground

@OdinVex
Copy link
Author

OdinVex commented Nov 14, 2024

Sorry the images are so large, 4K display.

@k-donn
Copy link
Owner

k-donn commented Nov 14, 2024

I've forgotten to mention, this has always been a thing too (see icons): Wunderground

I thought these icons looked familiar. Someone brought up this issue with #80. The fix for that involved changing the icons sizes to ones where papirus provided themable icons. Papirus doesn't provide themable icons for all sizes.

Try uninstalling the widget and reinstalling 3.3.1. It looks like your version hasn't gotten all the changes.

@OdinVex
Copy link
Author

OdinVex commented Nov 14, 2024

Which icons in particular should I check out? I know a lot of them are SVG, so it shouldn't matter what size?

Edit: Here's a fun one. If I turn off system icon theming every icon ends up looking normal and light as it should be. The wind direction shows a circle though (normal?). Icon in the tray ends up too small though, doesn't match the rest of the tray. Changing the details icon size did nothing (with/without system icons), changed nothing anywhere (selecting in the combobox also never enables the "save" button).

@k-donn
Copy link
Owner

k-donn commented Nov 14, 2024

I've forgotten to mention, this has always been a thing too (see icons): Wunderground

images provided

For day 19, weather-many-clouds does not have a weather-many-clouds-symbolic for sizes 48x48 and up. The icons are SVGs but somewhere in the rendering pipeline it chooses one of those files to use.

@OdinVex
Copy link
Author

OdinVex commented Nov 14, 2024

For day 19, weather-many-clouds does not have a weather-many-clouds-symbolic for sizes 48x48 and up. The icons are SVGs but somewhere in the rendering pipeline it chooses one of those files to use.

Edit: I looked at the icons from Papirus and weather-many-clouds size 48 is available, non-symbolic.

weather-clear-night-symbolic
weather-overcast-symbolic
weather-storm-symbolic
weather-clear-symbolic
weather-severe-alert-symbolic
weather-tornado-symbolic
weather-few-clouds-night-symbolic
weather-showers-scattered-symbolic
weather-windy-symbolic
weather-few-clouds-symbolic
weather-showers-symbolic
weather-fog-symbolic
weather-snow-symbolic

Unfortunately it's missing a few but these are SVGs from Papirus, symbolics.

@OdinVex
Copy link
Author

OdinVex commented Nov 14, 2024

At this point: System icons = correct size but wrong color, without system icons = wrong size but correct color. Details icon size changes nothing.

@k-donn
Copy link
Owner

k-donn commented Nov 14, 2024

The details icon size box auto-applies so it's expected that it wouldn't prompt an apply. But, it should still actually change the size of the icons.

For the details screen, the widget now uses the custom bundled icons for the wind display. So a circle for 0-2kts of wind is the standard wind barb. That should show up regardless of whether use system icons is checked. So, a block showing up for the wind is an error on its own.

Thanks for bringing this to my attention. I will have to look more in depth tomorrow.

@k-donn k-donn mentioned this issue Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants