From b0474a15cb16f014613ce247dfdcf85c0ea55547 Mon Sep 17 00:00:00 2001
From: jxmot <webdev@stupiddog.net>
Date: Tue, 31 May 2022 11:21:16 -0500
Subject: [PATCH] some refactoring, modified to use a JSON file for error codes
 and msgs

---
 errpages/httperror.php | 87 +++++++++++++-----------------------------
 1 file changed, 26 insertions(+), 61 deletions(-)

diff --git a/errpages/httperror.php b/errpages/httperror.php
index cea8731..f4a57e1 100644
--- a/errpages/httperror.php
+++ b/errpages/httperror.php
@@ -23,13 +23,6 @@ function isHTTPS() {
 }
 
 $http_status = 0;
-$error_code = '';
-$explanation = '';
-// post-error redirection, place a path to a resource below
-// in the `case` statments and it will be redirected to 
-// automatically after `$redirect_delay` seconds.
-$redirect_to = '';
-$redirect_delay = 10;
 
 // get ready...
 if(defined('_DEBUG') && _DEBUG === true) {
@@ -44,60 +37,6 @@ function isHTTPS() {
     $server_url = (isHTTPS() ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . '/';
 }
 
-// check the server's error code...
-switch($http_status) {
-	# '400 - Bad Request'
-	case 400:
-	$error_code = '400 - Bad Request';
-	$explanation = 'The syntax of the URL submitted by your browser could not be understood. Please verify the address and try again.';
-    // edit as needed for each `$http_status`
-	$redirect_to = '';
-	break;
-
-	# '401 - Unauthorized'
-	case 401:
-	$error_code = '401 - Unauthorized';
-	$explanation = 'This section requires a password or is otherwise protected. If you feel you have reached this page in error, please return to the login page and try again, or contact the webmaster if you continue to have problems.';
-	$redirect_to = '';
-	break;
-
-	# '403 - Forbidden'
-    # might be handled by the server instead of here
-	case 403:
-	$error_code = '403 - Forbidden';
-	$explanation = 'This section requires a password or is otherwise protected. If you feel you have reached this page in error, please return to the login page and try again, or contact the webmaster if you continue to have problems.';
-	$redirect_to = '';
-	break;
-
-	# '404 - Not Found'
-	case 404:
-	$error_code = '404 - Not Found';
-	$explanation = 'The requested resource: <span>' . $page_redirected_from . '</span>, could not be found on this server. Please verify the address and try again.';
-    if(defined('_DEBUG') && _DEBUG === true) {
-        $redirect_to = 'https://google.com';
-    } else {
-        $redirect_to = '';
-    }
-	break;
-
-	# '405 - Method Not Allowed'
-	case 405:
-	$error_code = '405 - Method Not Allowed';
-	$explanation = 'The request method is known by the server but has been disabled and cannot be used.';
-	$redirect_to = '';
-	break;
-
-    # everything else...
-    default:
-    $error_code = $http_status . ' - Unknown';
-	$explanation = 'Something bad happened, sorry!.';
-	$redirect_to = '';
-    break;
-}
-
-define('SRVNAME',   ((isset($_SERVER['SERVER_NAME']) === true) ? $_SERVER['SERVER_NAME']  : 'none'));
-define('REMADDR',   ((isset($_SERVER['REMOTE_ADDR']) === true) ? $_SERVER['REMOTE_ADDR']  : 'none'));
-
 /*
     cidrmatch() - returns `true` only if the IP 
     falls within the CIDR
@@ -119,6 +58,9 @@ function cidrmatch($ip, $cidr)
     isLive() - returns `true` if this script is 
     running on a "live" server
 */
+define('SRVNAME',   ((isset($_SERVER['SERVER_NAME']) === true) ? $_SERVER['SERVER_NAME']  : 'none'));
+define('REMADDR',   ((isset($_SERVER['REMOTE_ADDR']) === true) ? $_SERVER['REMOTE_ADDR']  : 'none'));
+
 function isLive() {
     $ret = ((SRVNAME !== 'localhost') && 
             (SRVNAME !== '127.0.0.1') && 
@@ -147,6 +89,29 @@ function isLive() {
     require_once $imagepool;
 }
 
+$error_code = '';
+$explanation = '';
+// post-error redirection, it will be redirected 
+// automatically after `$redirect_delay` seconds.
+$redirect_to = '';
+$redirect_delay = 10;
+
+define('REDIRECT', 0);
+define('ERROR_CODE', 1);
+define('EXPLANATION', 2);
+
+$errorcodes  = json_decode(file_get_contents('./errpages/httperror.json'), true);
+
+if(@$errorcodes["{$http_status}"]) {
+    $error_code  = $errorcodes["{$http_status}"][ERROR_CODE];
+    $explanation = $errorcodes["{$http_status}"][EXPLANATION];
+    $redirect_to = $errorcodes["{$http_status}"][REDIRECT];
+} else {
+    $error_code  = $http_status . ' - Unknown';
+	$explanation = 'Something bad happened, sorry!.';
+	$redirect_to = '';
+}
+
 // this will help defeat forced caching, like some android
 // browsers. they even ignore the anti-caching meta tags.
 $randquery = '?' . (microtime(true) * 10000);