Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about demo #53

Open
Hannibal046 opened this issue Jun 19, 2024 · 1 comment
Open

about demo #53

Hannibal046 opened this issue Jun 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Hannibal046
Copy link

Hi, @jxmorris12
Thanks so much for this insightful work! After trying the demo, I got the following results, which doesn't align with the output provided. So I want to confirm if the model updated or codebase refactored?
image

@jxmorris12 jxmorris12 added the bug Something isn't working label Jun 24, 2024
@jxmorris12
Copy link
Owner

Huh, yeah, this is really strange. Your outputs look marginally worse which makes me think this might be related to #40.

I'll try to think about what could have changed. I guess anything that changes the floating-point output of a transformer (even if it's the within a very small L2 of the original) could slightly decrease performance, which you're observing. Maybe we just need to pin to the versions (huggingface & pytorch) from a year ago when these models were trained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants