Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

But in documentation in SystemTextSerializer says it uses System.Text instead of Newtonsoft.Json #503

Open
dje1990 opened this issue Jul 4, 2024 · 2 comments

Comments

@dje1990
Copy link

dje1990 commented Jul 4, 2024

The inline documentation is wrong.
Please update line 9 in SystemTextSerializer.cs
to say:
/// JSON serializer using System.Text implementation.
instead of incorrectly saying it uses Newtonsoft.Json

see line 9 of SystemTextSerializer.cs
https://github.com/jwt-dotnet/jwt/blob/d6b1e4e76d45e7493970d177c6138b8174ff62c2/src/JWT/Serializers/SystemTextSerializer.cs#L9C31-L9C41

@abatishchev
Copy link
Member

Please consider submitting submitting a PR to fix it. Thanks!

@abatishchev abatishchev changed the title Please fix documentation in SystemTextSerializer to say it uses System.Text instead of Newtonsoft But in documentation in SystemTextSerializer says it uses System.Text instead of Newtonsoft.Json Jul 4, 2024
@abatishchev
Copy link
Member

Ping on a contribution to the project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants