Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a User I want to add single link to my Pocket #268

Open
tdziurko opened this issue Oct 16, 2016 · 12 comments
Open

As a User I want to add single link to my Pocket #268

tdziurko opened this issue Oct 16, 2016 · 12 comments

Comments

@tdziurko
Copy link
Collaborator

Each link to article/video at newsletter page should have small icon that allows user to add it to Pocket service.

@tdziurko
Copy link
Collaborator Author

I am on it.

@mgruca
Copy link
Collaborator

mgruca commented Jun 20, 2017

There was time, when I wanted to implement it, we may even talked about it. If there is a way now (back then I could not find one), I could help / take over this feature.

@tdziurko
Copy link
Collaborator Author

I have tried a bit but without any significant outcome so if you want I can assign this task to you. I can also push an outdated branch with my initial work so you could check it.

@tdziurko
Copy link
Collaborator Author

@mgruca so what is the status? :)

@mgruca
Copy link
Collaborator

mgruca commented Jun 30, 2017

looking at API ATM. Should be doable, API improved a lot since last time I was there. Assign it to me, will try to work on it after Confitura (let's check if I can still code :))

@mgruca
Copy link
Collaborator

mgruca commented Jun 30, 2017

erm, jak manager ma zakodować to lepiej zamknąć? ;)

@tdziurko tdziurko reopened this Jun 30, 2017
@tdziurko
Copy link
Collaborator Author

Wrong click :)

@mgruca mgruca self-assigned this Jul 8, 2017
@tdziurko
Copy link
Collaborator Author

tdziurko commented Dec 2, 2017

Making it available to take due to inactivity.

@rumid
Copy link
Contributor

rumid commented Jan 12, 2020

I am on it

@rumid
Copy link
Contributor

rumid commented Jan 16, 2020

With basic tweaks it looks like that:
image and it saves with jvm-bloggers short uri, so you don't know
what pocket element is about.
I will have to modify official pocket script (https://getpocket.com/publisher/button).
@tdziurko do you have any feedback regarding positioning of the button? Is it clear which button is responsible for which link?
I was considering adding it right after author with css:flex-box, change every second row background - it doesn't look good - or showing button, when mouse is pointing the link, but I haven't check it how to handle it for mobiles 🤔

@tdziurko
Copy link
Collaborator Author

I am a bit afraid how page will look with.... tens of such buttons 🤔

What do you think about:
1a. Changing button to black-white version
1b. Reducing it to only a logo without Pocket part?
2. Showing it only on-hover for each item.
3. Showing it right after the author?

Maybe if we add on-hover next to each link, applying 1a/1b won't be necessary as there will be only one button visible at a time?

For mobile: I have no idea how to handle on-hover so we could ignore this problem for now :)

@rumid
Copy link
Contributor

rumid commented Mar 1, 2020

Makes sense. I will apply 2 and 3 and experiment with 1a/1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants