Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom.scss and setup.scss postprocessing issue #1465

Open
saunders-hayes opened this issue Apr 24, 2024 · 4 comments
Open

custom.scss and setup.scss postprocessing issue #1465

saunders-hayes opened this issue Apr 24, 2024 · 4 comments
Labels
bug status: needs reproducible example Issues that need a reproducible example before they can be properly triaged.

Comments

@saunders-hayes
Copy link

saunders-hayes commented Apr 24, 2024

Recently, a new change occurred that broke custom.scss code.

Example:

  • in setup.scss: $sidebar-width: 260px;
  • in custom.scss: margin-left: Max($sidebar-width, calc((100% - 92.5rem) / 2 + $sidebar-width));
image

This is now generating an invalid property value because the second $sidebar-width does not resolve to its value. It looks like some extra space is being inserted instead between "$" and "sidebar-width".

Note: This was working fine until recently.

@mattxwang
Copy link
Member

Hi @saunders-hayes, thanks for submitting an issue. Would you be able to provide more context (ideally, a repository) to help us reproduce this problem? I can't strictly reproducing by making the suggested edits locally on a blank template theme (i.e. if I reproduce the steps written above, the $sidebar-width is properly interpreted as a SASS variable and the correct value is substituted in).

@mattxwang mattxwang added the status: needs reproducible example Issues that need a reproducible example before they can be properly triaged. label Apr 25, 2024
@saunders-hayes
Copy link
Author

@mattxwang Hm, our repository is private, but you can view our source here: https://apidocs.anrok.com/tutorials/

We were able to fix the bug by specifying a specific stable version in our _config.yml: just-the-docs/[email protected]

@mattxwang
Copy link
Member

Hi @saunders-hayes, thanks for your response. Just to confirm, does bumping to 0.8.2 (the latest version) break your site? This would surprise me since there is only one commit between the two versions (328893d), and this commit doesn't touch custom.scss.

@saunders-hayes
Copy link
Author

@mattxwang I believe the problem was that we didn't specify a version in our first implementation. Once we specified a version, our site worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status: needs reproducible example Issues that need a reproducible example before they can be properly triaged.
Projects
None yet
Development

No branches or pull requests

2 participants