Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

”Run Selected Code" default shortcut "Shift + Enter" not working in text editor on Jupyterlab 4.3.0 #152

Open
HereticSK opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@HereticSK
Copy link

Description

When trying to run selected code in a text editor with vim mode enabled, the default keyboard shortcut "Shift + Enter" not does not work, the selected code is not sent to the console and run.

The following manual tests are done:

  • Enable vim mode, hit "Shift + Enter", fail
  • Enable vim mode, click "Run Selected Code" in run menu with mouse, succeed
  • Enable vim mode, change keyboard shortcut to "Ctrl + Enter", succeed
  • Disable vim mode, both keyboard shortcut and run menu succeed

Reproduce

  1. Open a python file with text editor, enable vim mode
  2. Create a console for this editor
  3. Try running selected code by hitting "Shift + Enter"

Context

  • Operating System and version: Arch Linux
  • Browser and version: Chrome Version 130.0.6723.70 (Official Build) (64-bit)
  • JupyterLab version: 4.3.0
  • jupyterlab-vim version: 4.1.4

Jupyterlab labextension list shows

JupyterLab v4.3.0
/home/sk/.local/pipx/venvs/jupyterlab/share/jupyter/labextensions
jupyterlab_pygments v0.3.0 enabled OK (python, jupyterlab_pygments)
@axlair/jupyterlab_vim v4.1.4 enabled OK (python, jupyterlab_vim)

This keyboard issue may have occurred as early as Jupyterlab version 4.2.0, when I had just upgraded to 4.2.0. But I did not try disabling vim mode and changing to a different shortcut at that time. I simply rolled back to versions < 4.2.0 to work around. Until recently 4.3.0 released, I upgraded and found the issue still not fixed. I tried disabling vim mode and changing to a different to do further investigation.

Same issue was raised in jupyterlab repo jupyterlab/jupyterlab#16939

@HereticSK HereticSK added the bug Something isn't working label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant