From c8cc5febb0bcc419efb0b801108b97a946a71364 Mon Sep 17 00:00:00 2001 From: Joel Ostblom Date: Thu, 12 Oct 2023 09:58:44 -0700 Subject: [PATCH] Clarify settings location (#116) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Clarify settings location * Update modify-keybinds.md Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> --------- Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> --- modify-keybinds.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modify-keybinds.md b/modify-keybinds.md index fe6b2d4..89e1695 100644 --- a/modify-keybinds.md +++ b/modify-keybinds.md @@ -23,6 +23,6 @@ Jupyterlab commands don't know about the concept of vim modes so they will be ac ### Vim remappings -Vim style remappings (`inoremap`, `imap`, `nmap`...) can be modified in the advanced settings editor under the `Notebook Vim` settings. Alternatively, you can use the sibling extension [jupyterlab-vimrc](https://github.com/ianhi/jupyterlab-vimrc#jupyterlab-vimrc) to do this. +Vim style remappings (`inoremap`, `imap`, `nmap`...) can be modified in the Settings Editor under the `Notebook Vim` settings. Alternatively, for JupyterLab <4 you can use the sibling extension [jupyterlab-vimrc](https://github.com/ianhi/jupyterlab-vimrc#jupyterlab-vimrc) to do this. With either approach, Vim remappings do not work with everything you may have in your standard vimrc. Jupyterlab uses [Codemirror] for the editors in cells. This extension adds vim support by enabling the [vim](https://github.com/replit/codemirror-vim) emulation in codemirror. While this comes with partial support for remappings in your vimrc the support is incomplete. In particular, keybindings which use `noremap` don't work [unless the keybinding already exists in the default Codemirror Vim keybindings](https://github.com/replit/codemirror-vim/blob/2242fb71a1954e516150de61d416f41bcd3f0e3c/src/vim.js#L799-L801). If your keybinding doesn't work with `noremap`, try using `map`, and above all, avoid recursive remappings.