Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #52: do not emit if unchanged #53

Merged

Conversation

michaelchia
Copy link
Contributor

Only emit signal if path has changed.

Fixes #52.

Copy link

Binder 👈 Launch a Binder on branch michaelchia/jupyterlab-unfold/fix-pathchanged-signal

@martinRenou martinRenou added the bug Something isn't working label May 31, 2024
@martinRenou
Copy link
Member

I believe the failure of the CI is no related to your PR but to #49 which was merged around the same time as yours right before the broken release.

I'll have a look at fixing it right now.

@martinRenou
Copy link
Member

Hopefully #54 will make the CI green

@martinRenou martinRenou force-pushed the fix-pathchanged-signal branch from 4dffbac to 5f893b2 Compare May 31, 2024 08:37
@martinRenou martinRenou force-pushed the fix-pathchanged-signal branch from ed9bc03 to c86761d Compare May 31, 2024 09:28
@martinRenou
Copy link
Member

All good! Thanks!

@martinRenou martinRenou merged commit f8bcc54 into jupyterlab-contrib:master May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right click file/folder not possible since 0.3.1
2 participants