-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal Dockerfile example yields broken notebook (404: not found) on mybinder.org #240
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
That'll be due to the default URL changing to jupyterlab jupyterhub/binderhub#1354 Options are to either change the binder badge to pass |
I also get the same problem when pasting the link to the GitHub repo on the mybinder.org starting page, so it's probably all links that are generated there: https://mybinder.org/v2/gh/binder-examples/minimal-dockerfile/HEAD |
mybinder.org will try to send you to the URL at which JupyterLab is, but because the minimal example doesn't install JupyterLab you get a 404. This means that the minimal example needs updating so that it installs Jupyter Lab. Do you want to tackle that in a PR to https://github.com/binder-examples/minimal-dockerfile? |
So that basically means that Docker Containers without JupyterLab are no longer really supported on mybinder.org? |
Not quite. You can make a container that doesn't have lab installed but then you will have to specify the URL that users should be redirected to because the default URL is the one JupyterLab uses. Yes, there are unfortunately a lot of places in the docs that need updating that haven't yet been updated. |
I opened PRs in #243, binder-examples/minimal-dockerfile#4 and binder-examples/minimal-dockerfile#5, feel free to edit them as you deem suitable. I also didn't update the example overview page, as that probably needs the other PRs merged and I currently have no environment at hand to actually run the script. |
Opening any of the two binder links of the minimal Dockerfile example yields a notebook that simply displays a 404 error page:
master branch
truly-minimal branch
Running
jupyter-repo2docker https://github.com/binder-examples/minimal-dockerfile
locally yields a working notebook.The text was updated successfully, but these errors were encountered: