Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type check our JS #1898

Open
yuvipanda opened this issue Dec 21, 2024 · 0 comments
Open

Type check our JS #1898

yuvipanda opened this issue Dec 21, 2024 · 0 comments

Comments

@yuvipanda
Copy link
Collaborator

Our JS has some type information, which you can check by running npx tsc --noEmit --checkJs from the base. We aren't using typescript as a language, but using jsdoc hints to tell typescript what our types are.

We don't currently enforce it because our code doesn't actually cleanly typecheck! We should decide if we want it to, and then work towards that.

@yuvipanda yuvipanda mentioned this issue Dec 21, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant