You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of #1891, we're using the sync playwright api even in our async tests. playwright's sync api is written as a wrapper on top of its async api, so we have to use some hacks to use it given we have async tests.
JupyterHub implements its own pytest fixture, however that means we don't get the ability to upload traces for debugging only on failure. We could implement that ourselves too, but using the upstream provided pytest plugin feels better longer term.
As part of #1891, we're using the sync playwright api even in our async tests. playwright's sync api is written as a wrapper on top of its async api, so we have to use some hacks to use it given we have async tests.
so we currently have: async -> sync -> async
We can switch to pytest-playwright-asyncio and cut out the middle sync part.
I spent 30min trying this out as part of #1891, with this diff:
However, I could not get it to work - things seem to get stuck in the
await page.goto
.The text was updated successfully, but these errors were encountered: