Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in https://github.com/jupyterhub/binderhub/blob/main/docs/source/api.rst #1841

Open
rickmcgeer opened this issue Apr 3, 2024 · 3 comments
Labels

Comments

@rickmcgeer
Copy link

Bug description

The link to notebook accepts security tokens gives a 404.

How to reproduce

Click on the link in this issue or go to BinderHub API documentation and click on the link. It's under the heading "Ready"

Expected behaviour

I expected to go to that page

Actual behaviour

Got a 404

Your personal set up

Obviously, the setup isn't really relevant for this issue.

  • OS:
  • Version(s):
Full environment
# paste output of `pip freeze` or `conda list` here
Configuration
# jupyterhub_config.py
Logs
@rickmcgeer rickmcgeer added the bug label Apr 3, 2024
Copy link

welcome bot commented Apr 3, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@rickmcgeer
Copy link
Author

The proposed fix got chopped from the template, so here it is:

The dead link is on line 131 of https://github.com/jupyterhub/binderhub/blob/main/docs/source/api.rst. I'd propose a fix but I don't know where the page has moved. My guess is it's this: https://jupyter-notebook.readthedocs.io/en/5.7.1/security.html, but I'm not dead sure. Or it may be that the real problem (and this would be for the Jupyter repo) is that the link https://jupyter-notebook.readthedocs.io/en/security.html should point to a current version. If it's the latter, I'll be happy to file the appropriate report there and close this one.

@manics
Copy link
Member

manics commented Apr 30, 2024

Thanks for pointing that out! The notebook repo used to be the backend and front-end. The backend was split out into jupyter-server, the front-end was kept in the notebook repo but was updated to a new framework based on jupyterlab.

I think https://jupyter-server.readthedocs.io/en/stable/operators/security.html or the equivalent versioned URL is the best replacement.

Technically we're still running the old version of notebook without jupyter-server, but given we're going to have to update at some point I think we might as well use the jupyter-server docs for this so we don't forget to update it again
jupyterhub/repo2docker#1095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants