Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate binderhub's frontend UI from root folder #1707

Open
Tracked by #1667
consideRatio opened this issue May 30, 2023 · 1 comment
Open
Tracked by #1667

Relocate binderhub's frontend UI from root folder #1707

consideRatio opened this issue May 30, 2023 · 1 comment
Labels
help wanted maintenance Under the hood improvements and fixes

Comments

@consideRatio
Copy link
Member

consideRatio commented May 30, 2023

I'd like to compartmentalize things to help me understand the binderhub repo's code better. We now have a binderhub-client JS package to work against the binderhub REST API (/build) as a package to publish to NPM, and another one not to publish related to the binderhub's frontend.

The binderhub-client content is located clearly in js/packages/binderhub-client. I propose we try to locate the binderhub-ui parts to js/packages/binderhub-ui, or possibly binderhub/static/src or similar.

Overview of binderhub frontend js

  • webpack.config.js, references:
    • binderhub/static/js/index.js, references:
      • src/badge.js
      • src/loading.js
      • src/path.js
      • ../index.css
  • package.json
  • babel.config.json
  • .eslintrc.js

Help wanted

I don't know enough about this to get this done efficiently, but I think it would be really good to get done.

@consideRatio consideRatio added maintenance Under the hood improvements and fixes help wanted labels May 30, 2023
@manics
Copy link
Member

manics commented May 30, 2023

Sounds fine to me. I'll add this to #1667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted maintenance Under the hood improvements and fixes
Projects
None yet
Development

No branches or pull requests

2 participants