From fe87f69229e4bef8b120a94feb7c101f393126ef Mon Sep 17 00:00:00 2001
From: Steven Silvester <steven.silvester@ieee.org>
Date: Sun, 20 Nov 2022 11:35:32 -0600
Subject: [PATCH] More cleanup (#1077)

* more test cleanup

* add codecov badge

* remove unused env var
---
 .github/workflows/check-release.yml     | 22 ---------------------
 .github/workflows/downstream.yml        | 15 ++++++++++++++
 .github/workflows/integration-tests.yml |  1 -
 .github/workflows/python-tests.yml      | 26 +++++++++++++++++++------
 README.md                               |  1 +
 5 files changed, 36 insertions(+), 29 deletions(-)
 delete mode 100644 .github/workflows/check-release.yml

diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml
deleted file mode 100644
index 687f028d25..0000000000
--- a/.github/workflows/check-release.yml
+++ /dev/null
@@ -1,22 +0,0 @@
-name: Check Release
-on:
-  push:
-    branches: ["main"]
-  pull_request:
-    branches: ["*"]
-
-jobs:
-  check_release:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-      - name: Base Setup
-        uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
-      - name: Install Dependencies
-        run: |
-          pip install -e .
-      - name: Check Release
-        uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml
index a49fdcdd4e..7e3df1cb12 100644
--- a/.github/workflows/downstream.yml
+++ b/.github/workflows/downstream.yml
@@ -100,3 +100,18 @@ jobs:
         uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
         with:
           package_name: jupyter_server_terminals
+
+  downstream_check: # This job does nothing and is only used for the branch protection
+    if: always()
+    needs:
+      - jupyterlab
+      - jupyter_server_terminals
+      - jupyterlab_server
+      - notebook
+      - nbclassic
+    runs-on: ubuntu-latest
+    steps:
+      - name: Decide whether the needed jobs succeeded or failed
+        uses: re-actors/alls-green@release/v1
+        with:
+          jobs: ${{ toJSON(needs) }}
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
index 57693a166b..658e072568 100644
--- a/.github/workflows/integration-tests.yml
+++ b/.github/workflows/integration-tests.yml
@@ -29,7 +29,6 @@ jobs:
         run: |
           hatch run cov:integration
 
-
   integration_check: # This job does nothing and is only used for the branch protection
     if: always()
     needs:
diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml
index f9edcd0a28..6049d069f4 100644
--- a/.github/workflows/python-tests.yml
+++ b/.github/workflows/python-tests.yml
@@ -51,7 +51,7 @@ jobs:
           pip install codecov
           codecov
 
-  pre-commit:
+  pre_commit:
     name: pre-commit
     runs-on: ubuntu-latest
     steps:
@@ -96,7 +96,6 @@ jobs:
           only_create_file: 1
       - name: Run the unit tests
         run: |
-          export PIP_CONSTRAINT="./contraints_file.txt"
           hatch run test:nowarn || hatch run test:nowarn --lf
 
   test_prereleases:
@@ -110,8 +109,7 @@ jobs:
           python_version: "3.11"
       - name: Run the tests
         run: |
-          export PIP_PRE=1
-          hatch run test:nowarn || hatch run test:nowarn --lf
+          PIP_PRE=1 hatch run test:nowarn || hatch run test:nowarn --lf
 
   make_sdist:
     name: Make SDist
@@ -134,6 +132,21 @@ jobs:
           package_spec: .
           test_command: hatch run test:test || hatch run test:test --lf
 
+  check_release:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Base Setup
+        uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
+      - name: Install Dependencies
+        run: |
+          pip install -e .
+      - name: Check Release
+        uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+
   check_links:
     name: Check Links
     runs-on: ubuntu-latest
@@ -143,15 +156,16 @@ jobs:
       - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
       - uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
 
-  python_tests_check: # This job does nothing and is only used for the branch protection
+  tests_check: # This job does nothing and is only used for the branch protection
     if: always()
     needs:
       - build
-      - pre-commit
+      - pre_commit
       - test_docs
       - test_minimum_versions
       - test_prereleases
       - check_links
+      - check_release
       - test_sdist
     runs-on: ubuntu-latest
     steps:
diff --git a/README.md b/README.md
index 27d8721109..18e8415ba8 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,7 @@
 # Jupyter Server
 
 [![Build Status](https://github.com/jupyter-server/jupyter_server/actions/workflows/python-tests.yml/badge.svg?query=branch%3Amain++)](https://github.com/jupyter-server/jupyter_server/actions/workflows/python-tests.yml/badge.svg?query=branch%3Amain++)
+[![codecov](https://codecov.io/gh/jupyter-server/jupyter_server/branch/main/graph/badge.svg?token=S9WiBg2iL0)](https://codecov.io/gh/jupyter-server/jupyter_server)
 [![Documentation Status](https://readthedocs.org/projects/jupyter-server/badge/?version=latest)](http://jupyter-server.readthedocs.io/en/latest/?badge=latest)
 
 The Jupyter Server provides the backend (i.e. the core services, APIs, and REST endpoints) for Jupyter web applications like Jupyter notebook, JupyterLab, and Voila.