Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releaser 1.x is failing with Invalid request.\n\nFor 'properties/body', true is not a string or null. #516

Open
echarles opened this issue Jun 26, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@echarles
Copy link
Member

I am trying to release JupyterLab 3.6 and failing on https://github.com/echarles/jupyter_releaser/actions/runs/5374724197/jobs/9750411116

with

====Error Body====
{
"message": "Invalid request.\n\nFor 'properties/body', true is not a string or null.",
"documentation_url": "https://docs.github.com/rest/reference/pulls#create-a-pull-request"
}

This is probably du to recent changes in jhapi changes, see #512 by @blink1073

I discussed that with @jtpio and @fcollonval who proposed to migrate JupyterLab to Jupyter Release V2. However other repos may still depend on 1.x. Should we pin "ghapi<=1.0.4" also for 1.x?

@echarles echarles changed the title Releaser 1.x fails Releaser 1.x is failing with Invalid request.\n\nFor 'properties/body', true is not a string or null. Jun 26, 2023
@fcollonval fcollonval added the bug Something isn't working label Jun 26, 2023
@echarles
Copy link
Member Author

I have just tried in my fork with the pin echarles@55e05ed

Using that fix, the issue exact is still showing up.

====Error Body====
{
"message": "Invalid request.\n\nFor 'properties/body', true is not a string or null.",
"documentation_url": "https://docs.github.com/rest/reference/pulls#create-a-pull-request"
}

@blink1073
Copy link
Contributor

I'm afk all week

@echarles
Copy link
Member Author

Thx for letting us know Steve. Enjoy your week off, we are taking care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants