Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve labelling of the interval options #544

Open
krassowski opened this issue Sep 13, 2024 · 3 comments
Open

Improve labelling of the interval options #544

krassowski opened this issue Sep 13, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@krassowski
Copy link
Contributor

Problem

Users have reported being slightly lost with the options available in interval menu:

  • Users were confused on the difference between Day and Weekday

image

Proposed solution

Change the wording to use "Day" → "Every day" etc.

Proposal by @sketch0395

image

Additional context

Day of the month could have a dropdown menu with possible options:

image

while still allowing for direct user input. This might be easier for mouse-only users.

@krassowski krassowski added the enhancement New feature or request label Sep 13, 2024
@JasonWeill
Copy link
Collaborator

It might be good instead to list "every weekday" as "Monday to Friday". In predominantly Muslim and Jewish parts of the world, for example, weekdays are Sunday to Thursday, and Friday and Saturday constitute the weekend.

@sketch0395
Copy link

sketch0395 commented Sep 13, 2024

It might be good instead to list "every weekday" as "Monday to Friday". In predominantly Muslim and Jewish parts of the world, for example, weekdays are Sunday to Thursday, and Friday and Saturday constitute the weekend.

This is outstanding feedback, I will add that change to the mock-up. Thank you very much.

Edit: See iteration

image

@andrii-i andrii-i added this to the 3.0.0 milestone Sep 19, 2024
@andrii-i
Copy link
Collaborator

@krassowski @sketch0395 Thank you for creating this and #545, #546, #547. All of them make sense to me and would improve experience for the users.

For Jupyter Scheduler 3.0.0 planned for a late Q4 release a new workflows feature and a UI update are planned (please see PR #526 for a video with a demo of a target user experience and dag-scheduling branch for WIP front-end, you can install it and use it thanks to mocks). I added this issue and #545, #546, #547 to 3.0.0 milestone to take them all into account during the UI update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants