Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input file auto-update #524

Open
hardcore-code opened this issue Jun 3, 2024 · 7 comments
Open

Input file auto-update #524

hardcore-code opened this issue Jun 3, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@hardcore-code
Copy link

hardcore-code commented Jun 3, 2024

Problem

When we create a new job definition, the notebook is copied somewhere in the server.

Quite often you change that file and the you need to recreate everything.

Proposed solution

It would be incredible to have the option to retain the link to the original file. Kind of NO_COPY. It would save a lot of time.

Would be nice to have a way to have the job connected to a file path instead of saving a copy of the file that requires a manual update...

It could be an option during the creation/editing.

The field "url" that you have in the db table could be used for that purpose....

Maybe you would need to add an additional flag field called "linked". Once it is true, scheduler uses the url as a link to the file. Once false, use as it is now, a copy to a specific folder in the server.

@hardcore-code hardcore-code added the enhancement New feature or request label Jun 3, 2024
Copy link

welcome bot commented Jun 3, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@andrii-i
Copy link
Collaborator

andrii-i commented Jun 3, 2024

Hi @hardcore-code. Thank you for creating this issue. You can edit which input file / notebook job definition uses to create jobs using Edit Job Definition functionality. To do this:

  1. Go to the job definition detail page by clicking job definition name in the detail view
    Screenshot 2024-06-03 at 11 38 46 AM
  2. Choose "Edit Job Definition"
    Screenshot 2024-06-03 at 11 39 33 AM
  3. Drag a file from the filebrowser and drop it into the "Input file snapshot" input field. Then save changes
    Screenshot 2024-06-03 at 11 39 55 AM

@andrii-i
Copy link
Collaborator

andrii-i commented Jun 3, 2024

@hardcore-code I've created an issue #525 to track necessity to document how to update input file snapshots. Please try the functionality as described above. Closing as solved by existing functionality but feel free to ask follow-up questions, provide additional feedback, or even reopen if my reply above does not solve your issue.

@andrii-i andrii-i closed this as completed Jun 3, 2024
@hardcore-code
Copy link
Author

hardcore-code commented Jun 3, 2024 via email

@andrii-i
Copy link
Collaborator

andrii-i commented Jun 3, 2024

@hardcore-code

Would be nice to have a way to have the job connected to a file path instead of saving a copy of the file that requires a manual update...

It could be an option during the creation/editing.

The field "url" that you have in the db table could be used for that purpose....

Maybe you would need to add an additional flag field called "linked". Once it is true, scheduler uses the url as a link to the file. Once false, use as it is now, a copy to a specific folder in the server.

I think this makes a lot of sense as a feature request / potential new feature. Could you please edit the issue description adding the feature description quoted above to it? We could then reopen this issue and use it to track and discuss "Mutable input files" feature request. Otherwise no worries, I can create a new issue myself based on your comment.

By the way, great tool.

Than you, it's nice to hear that you find Jupyter Scheduler useful.

@andrii-i andrii-i changed the title Mutable input files Input file auto-update Jul 4, 2024
@andrii-i
Copy link
Collaborator

andrii-i commented Jul 4, 2024

I've edited the name and description of this issue to use it as a feature request.

@andrii-i andrii-i reopened this Jul 4, 2024
@alexboestari
Copy link

Hi @hardcore-code. Thank you for creating this issue. You can edit which input file / notebook job definition uses to create jobs using Edit Job Definition functionality. To do this:

  1. Go to the job definition detail page by clicking job definition name in the detail view
  2. Choose "Edit Job Definition"
  3. Drag a file from the filebrowser and drop it into the "Input file snapshot" input field. Then save changes

Hi.. I followed this step, it works only if I drag the notebook with different filename. If I re-drag the same notebook (with the same filename of course), it won't update on the scheduled jobs. Please advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants