Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fixes #1372

Merged
merged 5 commits into from
Mar 9, 2024
Merged

Docker fixes #1372

merged 5 commits into from
Mar 9, 2024

Conversation

lresende
Copy link
Member

@lresende lresende commented Mar 3, 2024

Docker fixes:

  • Update Debian security repository for the demo-base docker image
  • Use more recent TensorFlow base image as old one is unavailable

Fixes #1371

@lresende lresende requested a review from kevin-bates March 3, 2024 23:16
@lresende lresende force-pushed the docker-fixes branch 2 times, most recently from e6e33fc to 8e9053c Compare March 4, 2024 00:14
@lresende
Copy link
Member Author

lresende commented Mar 4, 2024

@kevin-bates any ideas on these build failures? do we need to update any of the jupyter infra for builds?

@luong-komorebi
Copy link
Contributor

Based on the logs, there is a high chance that link-check fails because of this breaking change from pytest pytest-dev/pytest#11779 on version 8.1, which I found that the job installed
445
The upstream package also did not lock the dependency so that pytest version should be <8.1

Therefore, from my view:

  1. In the short term, we can fix this by pre-installing pytest before this line is run
    - uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
  2. Long term, let's open a PR to the upstream to pin the version of pytest

@lresende
Copy link
Member Author

lresende commented Mar 9, 2024

Thank you @luong-komorebi , even though I had forced the pytest to be < 8.1 forcing install on the build file before link check seems to have resolved the issue.

@lresende lresende merged commit d01e84a into jupyter-server:main Mar 9, 2024
14 checks passed
@lresende lresende deleted the docker-fixes branch March 9, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image not found for 3.2.3 release
2 participants