fix: update useDarkMode to not reset with OS value on every refresh #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This PR fixes it for me — was always reverting to the OS default on every page load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
This PR does two things:
1. Update useLocalStorage save initial value
The way things are now, useLocalStorage does not correctly represents the value in the
localStorage. It returns a default value even if thekeydoesn't exist there yet and does not create it, meaning it returns a value that is not necessarily the truth (should beundefined. This causes a problem inuseDarkMode(and probably other hooks).The PR updates the hook to actually save the key/value in
localStoragewhen the hook is called, preserving the hook's initial funcionality.2. Update
useDarkModeto not reset with OS value on every refreshRemoves the
useIsomorphicLayoutEffectbecause it's unnecessary. The valueisDarkModewill always be correctly set.