-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename broken for macros #1272
Labels
Comments
Nope, this is just fundamentally broken I think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the following file:
I'm using LanguageServer.jl 4.5.1 with eglot. Please excuse the s-expression formatting of the JSON RPC requests/responses. So if I hover over
@add_2
and attempt to rename to@test
, I end up with the following file and see the following request/response pair:As you can see, the macro invocations are replaced correctly, but the macro definition has duplicate replacements of
add_2
with@test
. So probably two separate issues?@
sign should be stripped and need to only send the edit for the macro definition once.I thought perhaps that the issue was that the LanguageServer expected you to send the new name as
test
instead of@test
, but that didn't work either. Does renaming of macros work in the vs-code extension?The text was updated successfully, but these errors were encountered: