Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-review use EDITOR/editor #48

Open
LecrisUT opened this issue Jul 30, 2024 · 1 comment
Open

update-review use EDITOR/editor #48

LecrisUT opened this issue Jul 30, 2024 · 1 comment

Comments

@LecrisUT
Copy link

Right now when you run fbrnch update-review you can only customize the "Summary". But I would want to put in more detailed comments there, e.g. for rust packages I put the full rust2rpm.toml and *-fix-metadata.diff so that others can replicate locally or confirm I didn't upload an outdated srpm by mistake.

It would be nice if instead of a prompt, you would be put in an editor environment with the Spec, SRPM lines pre-populated so the user can freely edit the message. Like how git commit -s works.

@juhp
Copy link
Owner

juhp commented Aug 18, 2024

Using an editor seems frequent requested feature: I will try to do that in the next version

@juhp juhp changed the title update-review with more detailed message update-review use EDIT/editor Aug 18, 2024
@juhp juhp changed the title update-review use EDIT/editor update-review use EDITOR/editor Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants