-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering Campsites #86
Comments
Hey @stjohnjohnson apologies for the late reply here, I'm just getting back into things after a camping trip actually. I've been digging into this more and here's what I've found:
So here's my idea: when camply validates the underlying campgrounds it's going to be searching through it will also make an additional call to retrieve information about all of the related Equipment / Attributes of the underlying campsites it searches. Subsequently, when it finds available campsites within those campgrounds, it will look up that metadata and join it on the Campsite object. Once that data is included on the campsite object it will be relatively simple to filter on it during the search process. I have code I've been experimenting with, I will open up a branch and share that shortly. Hopefully we'll have a solution to this very soon. |
Okay, following up. I've been working on it over here and I'm close: #88 The trickiest part has been modifying how the underlying Data Containers handle hashing when some of their properties are lists (like attributes permitted equipment). Now that that is out of the way the last bits of work are in the details of the Implementation. Here are some remaining questions:
What should the user interface look like? Will someone only specify that they have a trailer/tent/RV or should they also specify the maximum length? |
Okay @stjohnjohnson I've made a ton of progress on this and just pushed the latest feature, the As part of this I've surfaced two new attributes on the Check out some of the data here:
|
@stjohnjohnson one more follow up. Will you test the Telegram notifications for me on |
A related question here: how can I filter by site type as shown in the screenshot above? e.g. Tent Only / Boat in / Hike to |
Hey @ArtixZ those properties are Filtering on attributes is coming as soon as I get some time to code it up |
@juftin Thanks a lot working on this! This project is really a high quality stuff. I'm an outdoor hiking/backpacking lover, and a SDE. If I can contribute anything on this, do let me know. |
@juftin Is there a way to filter on campsite type? Or an arbitrary filter string that includes/exclude on campsite name? I'm getting a lot of "boat in only" results ( |
Not yet, I'll find a way to eventually incorporate that into the campsite filtering feature. |
Hi. Thanks for creating this awesome repository. I am interested in the |
I’m looking to a filter the alerts I get to ones that meet my requirements (e.g. trailer size).
How would you recommend I implement this?
The text was updated successfully, but these errors were encountered: