Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docs/code change for Gen 2 Firebase Functions #213

Open
AndrewLester opened this issue May 28, 2023 · 0 comments
Open

feat: Docs/code change for Gen 2 Firebase Functions #213

AndrewLester opened this issue May 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@AndrewLester
Copy link
Contributor

Describe the problem

Gen 2 firebase functions require different imports and syntax in the functions/index.js file, which is seamless to edit and use with this library. That said, perhaps the content for the file, which is initially logged by the package, should use the gen 2 syntax. Alternatively, something could be added in the README to note the differences.

Describe the proposed solution

Something like the example in this file could be used:
https://github.com/AndrewLester/firebase-test/blob/main/functions/index.js

In addition, some note about making sure the function runs Node.js 18 would be helpful:
https://github.com/AndrewLester/firebase-test/blob/main/functions/package.json#L12

Alternatives considered

n/a

Importance

would make my life easier

@AndrewLester AndrewLester added the enhancement New feature or request label May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant