Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The default firestore.json file generates an array of functions #196

Open
kleber-swf opened this issue Dec 26, 2022 · 1 comment
Open
Labels
bug Something isn't working

Comments

@kleber-swf
Copy link
Contributor

kleber-swf commented Dec 26, 2022

Describe the Bug

Firebase 11.19.0 (dec/2022): running firebase init with functions setup generates the following snippet:

"functions": [
   {
      "source": "functions",
      "codebase": "default",
      "ignore": ["node_modules", ".git", "firebase-debug.log", "firebase-debug.*.log"]
   }
],
...

which is an array. The adapter expects an object.

Steps to Reproduce

  1. run firebase init and make sure you selected to setup firebase functions
  2. run npm run build
  3. The following error will throw: Error: Required "functions.source" field is missing from Firebase Configuration file.

Expected Behaviour

The adapter should accept this default configuration. Probably this will be the default to now on.

svelte-adapter-firebase version

0.14.4

sveltejs/kit version

1.0.1

@symbolicsorcerer
Copy link

symbolicsorcerer commented Jul 15, 2023

The fix is in main but not released. As a workaround in the meantime for folks, you can update package.json:

		"svelte-adapter-firebase": "git://github.com/jthegedus/svelte-adapter-firebase.git#a18d29b",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants