Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Paperclip ~>=2.3.16 (infinite save loop) #37

Open
maxim opened this issue Sep 9, 2011 · 7 comments
Open

Incompatible with Paperclip ~>=2.3.16 (infinite save loop) #37

maxim opened this issue Sep 9, 2011 · 7 comments

Comments

@maxim
Copy link

maxim commented Sep 9, 2011

Starting paperclip somewhere around 2.3.16, saving attachment with delayed_paperclip causes infinite saving loop as the model's attachment_updated_at attribute gets "touched" upon saving, and delayed_paperclip is recognizing that attachment has changed.

I am not sure exactly which version of Paperclip breaks delayed_paperclip, but I have determined that 2.3.11 works, while 2.3.16 or 2.4.1 (latest currently) doesn't.

@Bertg
Copy link
Contributor

Bertg commented Sep 9, 2011

Hi,

Paperclip has undergone quite a change in the latest release, making life easier for people who want to create plugins for it.

I'm currently on holiday, and won't be working on it (as promised to my GF). But I'm back on wednesday, and will be working on it then. I'm sorry for the inconvenience it's causing in the mean time.

@Bertg
Copy link
Contributor

Bertg commented Sep 18, 2011

Hi,

We now have test for this. I was checking and I'm not seeing any tests failing. http://travis-ci.org/#!/jstorimer/delayed_paperclip/builds/168893

Could you provide us with an example failing test/code?

@pabloalr
Copy link

pabloalr commented Nov 4, 2011

Are you sure those test are running against the latest paperclip ?

@pabloalr
Copy link

pabloalr commented Nov 4, 2011

By the way, tests are passing with paperclip 2.3.16, but not with ~2.4. I just cloned the repo and added a Appraisal setup for paperclip 2.4...

@Bertg
Copy link
Contributor

Bertg commented Nov 7, 2011

Hi,

I just added a bunch of version branches, each for every paperclip 2.4.x branch. The test seem to be working fine now.

Could you verify, or add some test that are failing per branch?

Also, could you have a look at this post (#46) in regards to future versioning?

@Bertg
Copy link
Contributor

Bertg commented Nov 7, 2011

Could you have a look at this (#47) patch?

I think it might fix your problem. If it does, could you please confirm?

@pabloalr
Copy link

pabloalr commented Nov 8, 2011

Hi Bert.

Just checked out 2.4.5 branch and everything is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants