Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version(v5.1.1) not bumping the version of a project if the changes made to the dependency. #785

Open
ak274 opened this issue Feb 13, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@ak274
Copy link

ak274 commented Feb 13, 2024

In my workspace when I am making changes to the feature libs of my app and committing changes after that when I run target to bump the version its not increasing the version of my app. It was working fine till 4.2.x.

I have reproduced the issue in the following repro repo:

https://github.com/ak274/semver

My App project.json for version target:

"version": {
      "executor": "@jscutlery/semver:version",
      "options": {
        "preset": "angular",
        "push": true,
        "commitMessageFormat": "chore({projectName}): release version ${version} [skip ci]",
        "baseBranch": "master",
        "noVerify": true,
        "releaseAs": "prerelease",
        "trackDeps": true,
        "preid": "beta"
      }
    },

Steps to reproduce:

  1. Make some change in the libs/demo/feature-lib 2) commit the feature with angular commit convention 3) push commit to the origin master
  2. run version target for the demo app
  3. it will say no changes since last release.

Expected behavior:

As I have made changes to a feature lib which is a dependency of app, It should bump the version for my app.

@ak274 ak274 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
@ak274
Copy link
Author

ak274 commented Feb 13, 2024

I'll reopen it once I am fully sure that issue exists, currently I can't reproduce it every time. So not sure what is causing this issue. In my actual project this issue is always there but not in the repro repository.

@ak274
Copy link
Author

ak274 commented Feb 14, 2024

Reopening the bug as now I'm sure that it will always fail version bump if you follow the repro steps.

@carlofaessler
Copy link

+1 on this...we're experiencing the same issue. Would be great if this could be fixed

@lucavb
Copy link
Contributor

lucavb commented Sep 5, 2024

Maybe I can raise my question here: would this help? #816

@ChristianBlitz
Copy link

The issue still exists, although a possible solution exists with #816. We would also be interested in the PR being merged. That would really help us because since the update to NX 19 our pipeline often fails.

@edbzn
Copy link
Member

edbzn commented Dec 4, 2024

I'd prefer not adding an extra option for that and simply track deps with prerelease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants