-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$.textillate('stop') doesn't work #98
Comments
The stop method was added by @kodeaffe in #47. I've never used it myself. I'm guessing since stop just clears the out animation timeout, calling it during the out transition will still cause the next in animation to fire, causing the out to fire again. I believe that the quick fix would be set something like Would gladly accept a PR for this or will have to wait until I get a moment to test out the fix. |
I have another issue with 'stop' method. I am wondering if any of you can help me finding solutions.
I put the fix, but it still doesn't work for it. |
@ohpyupi would you be able to post your fix in case in helps others? If I understand correctly, the root problem is that |
I was having an issue with stop method and tried to make a button to trigger stop button. To test whether it's actually working or not... I thought your fix cleared the problem, but I think it didn't. As you mentioned, during the animation, the stop method doesn't see base.timeoutRun. But when when the animation stops (a short interval between in-animation and out-animation). Original coding
So if I catch the moment when the animation stops and click the button that triggers stop method, then the animation can be stopped. what the button looks like
|
You can stop the loop after out animation by editing jquery.textillate.js and using a counter.
|
@lukalev |
Calling $.textillate('stop') doesn't work. Nothing happens. Can't find a working sample.
The text was updated successfully, but these errors were encountered: