-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JQ download autoselection causes HTTP 403 (rate limit) #9
Comments
I see your point; the goal was to allow the user to get the latest with some protections for checksum even if the user didn't choose. I think the specification of a version should take priority, but the checksum will still be problematic. TBH, the I'll look into that (but it may take until Thursday before I get time to look into it) |
thanks. I worked around this by getting a jq release with rules_download and running that binary in a ctx.actions.run_shell, so no rules_jq involved. |
Cool. Keep in mind: you'll have rate-limited downloads in GitHub unless you're using a valid token to authenticate to GitHub. I've run into this when I'm building using the default token. I'm not trying to be confrontational, but I wanted to warn you that this happens outside of this project. I can help you when you run into that. |
Thanks for the heads-up. We use a combination of persistent runners and vendor mode to avoid this. |
The issue comes from querying the API in
bazel_rules_jq/jq/repositories.bzl
Lines 37 to 40 in 1c14aed
Probably it would be better to blindly accept a jq version as input and just try download that
The text was updated successfully, but these errors were encountered: