Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding kid jwt header by default #976

Open
adamJLev opened this issue Aug 19, 2024 · 3 comments
Open

Consider adding kid jwt header by default #976

adamJLev opened this issue Aug 19, 2024 · 3 comments

Comments

@adamJLev
Copy link

adamJLev commented Aug 19, 2024

So it looks like PyJWKClient relies on this param to work at all, why not make it the default to include kid in the JWT headers?
If the field is empty or null, the JWK client will never match the key.

I realize kid is an optional field, but its useful and it would make sense to me to include it, as otherwise the client that comes with the library doesn't even work with JWT tokens signed by this library - which seems inconsistent.

More info on kid aka `key id" field: https://datatracker.ietf.org/doc/html/rfc7517#section-4.5
Andhere in a more user friendly format: https://fusionauth.io/articles/tokens/jwt-components-explained

@adamJLev adamJLev changed the title Why not embed kid by default? Consider adding kid jwt header by default Aug 19, 2024
@gagandeepp
Copy link
Contributor

interested @adamJLev please assign

Copy link

github-actions bot commented Dec 5, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label Dec 5, 2024
@adamJLev
Copy link
Author

adamJLev commented Dec 5, 2024

@gagandeepp I am not able to assign to you, I dont think I have permission. but would be great if you can add this soon :) thank you!

@github-actions github-actions bot removed the stale Issues without activity for more than 60 days label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants