Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate services like Anilist or similar #22

Open
josueBarretogit opened this issue Aug 26, 2024 · 17 comments · May be fixed by #63
Open

Integrate services like Anilist or similar #22

josueBarretogit opened this issue Aug 26, 2024 · 17 comments · May be fixed by #63
Assignees

Comments

@josueBarretogit
Copy link
Owner

No description provided.

@josueBarretogit josueBarretogit self-assigned this Aug 26, 2024
@justchokingaround
Copy link

would be great!

@crispy-caesus
Copy link

I'd also love this, only thing currently keeping me from using it

@josueBarretogit
Copy link
Owner Author

I'm going to be real with you all I dont know what anilist is XD like do you guys use it to keep a reading history? and if so how can I implement it? like when the user reads a chapter or downloads it then it is marked as read in their anilist account?

@josueBarretogit
Copy link
Owner Author

josueBarretogit commented Nov 3, 2024

  • Mark manga's chapter as read in anilist account when the user downloads or reads a chapter
  • what else?

@crispy-caesus
Copy link

it would be nice, if you could select from anilist lists, like there's currently reading dropped and planning lists

@crispy-caesus
Copy link

crispy-caesus commented Nov 4, 2024

I'm not sure if downloaded should necessarily mark as read, maybe optionally if possible? I'm not sure if people maybe like to just download a few dozen chapters ahead and then read them slowly

@crispy-caesus
Copy link

should I test this pr?

@josueBarretogit
Copy link
Owner Author

Hi at the moment it's not ready for review, when it is I'll assign you and put instructions, thanks for wanting to help out

@josueBarretogit
Copy link
Owner Author

@crispy-caesus It is now ready for review I'll appreciate your input 🫶

@crispy-caesus
Copy link

Sorry for the late reply, I was a bit busy yesterday

Error: PlatformFailure(Dbus(D-Bus error: The name is not activatable (org.freedesktop.DBus.Error.ServiceUnknown)))

I am getting this error after inputting the token,I got the same error in a debug build, though it does seem this is not a problem debug would fix.
Trying anilist check after, also throws an error accordingly

I'm not sure if this is a problem with my system or what this exactly means, I'd love to help more but yeah I got no clue about Rust

@josueBarretogit
Copy link
Owner Author

Ok can you tell me what os you are using? in order to store de access token I use a secret service which may not be installed on your system, if you are on linux try running sudo apt install libdbus-1-dev pkg-config

@crispy-caesus
Copy link

ahhh alright, I'll start that first then, makes sense

@crispy-caesus
Copy link

ahh yes thank you, now it works perfectly!!

@crispy-caesus
Copy link

other things that could maybe be added would be having some kind of access to your lists from anilist, so that you can just access your reading or planning to read lists from the home page, just like the recently added maybe, or have it be a search parameter.

when adding the app, I don't personally know how exactly it is handled by others, but all other apps I have, are added to anilist as an app, where you are essentially provided a link and then authorize them, instead of creating your own api endpoint.

those are of course just small quality of life things that could and I think should just be added as seperate issues and PRs

@josueBarretogit
Copy link
Owner Author

other things that could maybe be added would be having some kind of access to your lists from anilist, so that you can just access your reading or planning to read lists from the home page, just like the recently added maybe, or have it be a search parameter.

Sounds like a good idea, at the moment I want to integrate more services since I made it generic (dependency injection btw) so it should be easy

when adding the app, I don't personally know how exactly it is handled by others, but all other apps I have, are added to anilist as an app, where you are essentially provided a link and then authorize them, instead of creating your own api endpoint.

Oh I didn't know you could do that

those are of course just small quality of life things that could and I think should just be added as seperate issues and PRs

Thanks for taking your time in testing out this new feature, could you please comment LGTM in the pr so that I can assign you (and approve the pr please)

@crispy-caesus
Copy link

Thanks for taking your time in testing out this new feature, could you please comment LGTM in the pr so that I can assign you (and approve the pr please)

will do 👍

should I create separate issues for the other two things or how would you like to handle that?

@josueBarretogit
Copy link
Owner Author

will do 👍

I cant assign anybody i dont know why that is

should I create separate issues for the other two things or how would you like to handle that?

yeah those should be separate issues ill make them, thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants