Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TouchScrollable working only with vertical scrolling #39

Open
Krasnopir opened this issue Feb 19, 2019 · 7 comments
Open

TouchScrollable working only with vertical scrolling #39

Krasnopir opened this issue Feb 19, 2019 · 7 comments

Comments

@Krasnopir
Copy link

If we have an element with horizontal scrolling, it is possible to force TouchScrollable to scroll an element only by forcing not only the width limit, but also the height limit, in which the nested block must be at least 1 pixel more, then it works.

@jossmac
Copy link
Owner

jossmac commented Feb 19, 2019

Please provide a CodeSandbox reproduction.

@Krasnopir
Copy link
Author

I marked the place where you need to change the value to enable scroll
https://codesandbox.io/s/8pnlp437v8

@eballeste
Copy link

eballeste commented Mar 19, 2019

I'm seeing this in mobile devices where the height of a modal with a slideshow and captions is taller than the viewport height, if it's smaller than the viewport height it scrolls horizontally just fine, as soon as it hits a slide with content that's too tall swiping stops working

disabling scrollock in mobile is my current workaround

@eballeste
Copy link

also want to add that before disabling touch scrollable for mobile, I was doing tests thinking that it was some bug with the slider script, so I started by trying to manually trigger the previous/next methods of the slider by listening in on the touchstart/touchend events, only touchstart would fire. will try to recreate a sandbox once I have some free time but wanted to share this in the meantime in case it helps somehow

@Eugene-Musika
Copy link

relates to #42
Library seems abandoned though

@Eugene-Musika
Copy link

And also here is mine pull request with fix of current issue #98

@rick-liruixin
Copy link

They stopped the repairs. I had to do it myself, in the same way, with a new version of typeScript. And fix these problems for everyone to use. add react hooks、vue3 example

npm i body-scroll-lock-upgrade

repair log,Refer to the releases page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants