Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miliseconds #17

Open
benlieb opened this issue May 30, 2014 · 6 comments
Open

miliseconds #17

benlieb opened this issue May 30, 2014 · 6 comments

Comments

@benlieb
Copy link

benlieb commented May 30, 2014

Di you plan on implementing miliseconds? I started using this for an ffmpeg video editing project, and a lot can happen in a second on film. Ffmpeg has a function that tells you where a video fades to black at say at second 3535.3432. I wanted to store and manipulate these as Duration objects, but it's just not fine grained enough. Seem like a useful thing to have.

Any thoughts?

@benlieb
Copy link
Author

benlieb commented Aug 28, 2014

I've come back to check on this. If I submitted a pull request would you be interested in this functionality?

@peleteiro
Copy link
Collaborator

Not really. Adding microseconds would make this incompatible with ISO_8601.

@pkaeding
Copy link

I'm curious how supporting milliseconds would break compatibility with ISO 8601 durations? From the Wikipedia article linked above:

The smallest value used may also have a decimal fraction, as in "P0.5Y" to indicate half a year.

Thus, 237ms could be expressed in a ISO 8601-compatible format as P0.237S.

@peleteiro
Copy link
Collaborator

My mistake, you're right.
I'm fine with microseconds. You can submit the PR.

@peleteiro peleteiro reopened this Dec 29, 2014
@benlieb
Copy link
Author

benlieb commented Jul 2, 2018

I've come come back again to check on this, haha. But I guess neither I nor anyone else has had the time to implement micro / milliseconds. :(

@peleteiro
Copy link
Collaborator

I don't use ruby either this lib anymore. If someone else wants to implement microseconds and/or take over the project let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants