Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isValidationErrorChanged does not compare the error messsage #1627

Closed
Tethys0 opened this issue Nov 1, 2024 · 2 comments
Closed

isValidationErrorChanged does not compare the error messsage #1627

Tethys0 opened this issue Nov 1, 2024 · 2 comments

Comments

@Tethys0
Copy link

Tethys0 commented Nov 1, 2024

isValidationErrorChanged does not compare the messsage , if we have the same count of error message in the error array, though message is different , it won't trigger "onValidationError"

https://github.com/josdejong/jsoneditor/blob/develop/src/js/util.js#L1233https://github.com/josdejong/jsoneditor/blob/develop/src/js/util.js#L1233

We use custom validation and rely on onValidationError hook to reset the form control error.

@josdejong
Copy link
Owner

Thanks for reporting! We should improve this isValidationErrorChanged function.

Anyone able to help fix this? Help would be welcome.

@josdejong
Copy link
Owner

Fixed now in v10.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants