Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong implementation of skipto plugin on the joomla.org #2015

Open
zwiastunsw opened this issue Jul 31, 2024 · 2 comments
Open

Wrong implementation of skipto plugin on the joomla.org #2015

zwiastunsw opened this issue Jul 31, 2024 · 2 comments

Comments

@zwiastunsw
Copy link

  1. The SkipTo script on the Joomla.org homepage registers and displays links to all header and footer elements on the page. These are not the elements the aplugin should be displaying links to. Only the link to the page page header and footer page should be displayed in SkipTo. Headers and footers of elements other than the body element are not landmarks.

To correct this error, you can:

  • add role attributes to the header (page) and footer (page) tags: <header role="banner" class="header"> and <footer role="conteninfo" class="footer text-center">; in the script settings you must add: 'landmarks: 'main, [role="banner"], [role="conteninfo"]...',
  • or remove the header and footer tags in the ‘Download Joomla’, ‘Use Joomla’, ‘Learn Joomla’ modules.
  1. Links to nav elements do not have unique accessible names. If there is more than one landmark of a given type on a page, each must have a unique accessible name

To fix this error, add the aria-label attribute to nav elements, for example:
<nav class="navigation" role="navigation" aria-label="main">
<nav class="subnav-wrapper" aria-label="secondary">
<nav class="navbar navbar-expand" aria-label="secondary">
In footer:
<nav class="navbar navbar-expand" aria-label="socialmedia">
<nav class="navbar navbar-expand" aria-label="quick links">

joomla-org

@wilsonge
Copy link

The nav part of this issue has been fixed in the base template, there's one last fix to make before we roll it out. I'm expecting a rollout to the sites over the next 1-2 weeks.

Keeping this issue open because the template doesn't affect the markup on the joomla.org site itself for the 1st part.

@wilsonge
Copy link

Nav part now rolled out to all j4 sites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants