-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove button Cancel from Registration form #24000
Conversation
For A11Y reasons, as reported by Stefan Wadja and because in Web browser situations, like this, a 'Cancel' button is not needed, as the user can simply navigate away, if they don't want to commit, the 'Cancel' button is removed. In any case, there is no 'cancel' type for the <button> element, in HTML, so this can only be done by using CSS to make a <a> element look like a button 0r by making a normal button and adding Javascript. Neither is a good solution for an unnecessary button. Therefore, it is being removed.
I have tested this item ✅ successfully on 9a155e1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24000. |
1 similar comment
I have tested this item ✅ successfully on 9a155e1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24000. |
@zero-24 Please fix the rips issue. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24000. |
thanks |
I'd really like to see the evidence/research to back this up. |
I'm not convinced yet either |
Ok and my next question is. Is it easier for someone with disabilities (lets say someone blind in thise case) so find a cancel button (next to submit) or navigate back using the browser's back button? Not saying this PR is right or wrong but want definitely curious |
If a user (sighted or blind) wants to return to the previous page, he can only return using the browser function, because the Cancel button will not lead him to the previous page visited, but only to the homepage. |
As I said in the other repo . If its a form with "personal data" many people will feel happier to actively "cancel" if they change their mind about completing the form Regarding the a11y of the button "doing something other than what it announces" that is easy to fix.. |
@brianteeman , forgive me, but this is not an argument. Many people will be happy when they get $500. |
So far the only valid comment is that the current link going to the home page is wrong. that is easily fixed |
This is not the only valid comment. The valid comment is above all that this link/button is unnecessary. Other correct comments are those that show that in other forms you have the Submit button, but do not have the Cancel button. |
Sorry but I'm going to have to agree with Brian here. He made a very good point:
which from a UX perspective, is important. It feels like everyone is focusing too much on a11y and disregarding general UX. Both are as important as eachother. |
Forms very often contain personal data. And they do not contain the cancel button. You don't want to send them, you just don't send them. Getting the Cancel button makes sense e.g. in the Backend of Joomla. You make settings for the options. But you don't want to save them and you want to leave the edit/new. The only way - the Close or Cancel button. In this case it makes sense. |
You can use browser's back button in backend too. |
@SharkyKZ : Do you want to propose to remove the Close/Cancel buttons from the backend? This is not a good idea. There these buttons are useful. |
Leaving a form without saving or canceling in the backend leaves the edit item in the "checked in" state. In other words the item is locked. There is no way to just remove the cancel buttons in the backend without some serious architectural changes. Obviously people suggesting that don't really understand the fundamentals that Joomla is build upon... |
@dgrammatiko : This is already known from Joomla 1.0 and even from Mambo. But maybe @SharkyKZ doesn't know. |
@SharkyKZ @zwiastunsw this is a good reference: #4773 |
Thank you @dgrammatiko. But I do not propose to remove the Cancel buttons from the backend. I used their example to show when the Cancel button is needed. I didn't point to the important aspect you pointed out so as not to complicate this unnecessary discussion. The gentlemen are trying to prove to me that the Cancel button on the registration form has some magical, even necessary functions. I explain that this button does nothing good. I explain that it causes confusion and why. I explain that it is not needed for anything. I show examples that prove that it is unnecessary. No effect. I waste time discussing nothing. I know a lot of such minor faults and accessibility errors in Joomla. But when I think that there will be a discussion on every PR as during the defense of scientific dissertation, I don't know if I have the time, willingness and strength to do so. |
@zwiastunsw I wouldn't commended in the first place but I see a lot of people suggesting/making PRs that are totally against the architecture of the system. I feel that these need to be turned down asap... |
I'm suggesting the button should clear form data like in any other form. Especially since this concerns personal data. |
@SharkyKZ wrote:
Really? I would be grateful for any references.
(Ladies and) gentlemen, thank you all for this discussion. I really have learned a lot. I promise that this is my last 2 cents. |
thx |
For A11Y reasons, as reported by @zwiastunsw and because in Web browser situations, like this, a 'Cancel' button is not needed, as the user can simply navigate away, if they don't want to commit, the 'Cancel' button is removed.
In any case, there is no 'cancel' type for the button element, in HTML, so this can only be done by using CSS to make a element look like a button or by making a normal button and adding Javascript. Neither is a good solution for an unnecessary button.
Therefore, it is being removed.
Summary of Changes
'Cancel' button is removed.
Testing Instructions
Open the registration form and see that the 'Cancel' button no longer exists and that the screenreader behaves correctly.
Expected result
Better screenreader behaviour.
Actual result
Documentation Changes Required