Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove button Cancel from Registration form #24000

Merged
merged 2 commits into from
Jun 23, 2019

Conversation

tarot-ray
Copy link
Contributor

@tarot-ray tarot-ray commented Feb 24, 2019

For A11Y reasons, as reported by @zwiastunsw and because in Web browser situations, like this, a 'Cancel' button is not needed, as the user can simply navigate away, if they don't want to commit, the 'Cancel' button is removed.

In any case, there is no 'cancel' type for the button element, in HTML, so this can only be done by using CSS to make a element look like a button or by making a normal button and adding Javascript. Neither is a good solution for an unnecessary button.

Therefore, it is being removed.

Summary of Changes

'Cancel' button is removed.

Testing Instructions

Open the registration form and see that the 'Cancel' button no longer exists and that the screenreader behaves correctly.

Expected result

Better screenreader behaviour.

Actual result

Documentation Changes Required

For A11Y reasons, as reported by Stefan Wadja and because in Web browser situations, like this, a 'Cancel' button is not needed, as the user can simply navigate away, if they don't want to commit, the 'Cancel' button is removed. In any case, there is no 'cancel' type for the <button> element, in HTML, so this can only be done by using CSS to make a <a> element look like a button 0r by making a normal button and adding Javascript. Neither is a good solution for an unnecessary button.

Therefore, it is being removed.
@tarot-ray tarot-ray changed the title Update default.php [4.0][a11y] Remove button Cancel from Registration form Feb 24, 2019
@wojsmol
Copy link
Contributor

wojsmol commented Feb 24, 2019

I have tested this item ✅ successfully on 9a155e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24000.

1 similar comment
@zwiastunsw
Copy link
Contributor

I have tested this item ✅ successfully on 9a155e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24000.

@wojsmol
Copy link
Contributor

wojsmol commented Feb 24, 2019

@zero-24 Please fix the rips issue.

@Quy
Copy link
Contributor

Quy commented Feb 24, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24000.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-4.0-dev labels Feb 24, 2019
@zwiastunsw
Copy link
Contributor

thanks

@C-Lodder
Copy link
Member

I'd really like to see the evidence/research to back this up.

@brianteeman
Copy link
Contributor

I'm not convinced yet either

@zwiastunsw
Copy link
Contributor

@C-Lodder
Copy link
Member

Ok and my next question is. Is it easier for someone with disabilities (lets say someone blind in thise case) so find a cancel button (next to submit) or navigate back using the browser's back button?

Not saying this PR is right or wrong but want definitely curious

@zwiastunsw
Copy link
Contributor

zwiastunsw commented Feb 24, 2019

If a user (sighted or blind) wants to return to the previous page, he can only return using the browser function, because the Cancel button will not lead him to the previous page visited, but only to the homepage.
In addition:
The problem of whether this button is needed or not is not an accessibility problem. This is a UX problem.
Link/button will be accessible. The problem is that the button and the command on the button suggest an action (cancelling an action). But they don't perform actions, they just change the context (redirect to another page). And this is an aceesiibility error - do sth. other than what it announces.

@brianteeman
Copy link
Contributor

As I said in the other repo

. If its a form with "personal data" many people will feel happier to actively "cancel" if they change their mind about completing the form

Regarding the a11y of the button "doing something other than what it announces" that is easy to fix..

@zwiastunsw
Copy link
Contributor

@brianteeman , forgive me, but this is not an argument. Many people will be happy when they get $500.

@brianteeman
Copy link
Contributor

So far the only valid comment is that the current link going to the home page is wrong. that is easily fixed

@zwiastunsw
Copy link
Contributor

zwiastunsw commented Feb 24, 2019

So far the only valid comment is that the current link going to the home page is wrong.

This is not the only valid comment. The valid comment is above all that this link/button is unnecessary. Other correct comments are those that show that in other forms you have the Submit button, but do not have the Cancel button.
You do not need to cancel any operation in order not to send the form.

@C-Lodder
Copy link
Member

Sorry but I'm going to have to agree with Brian here. He made a very good point:

If its a form with "personal data" many people will feel happier to actively "cancel" if they change their mind about completing the form

which from a UX perspective, is important. It feels like everyone is focusing too much on a11y and disregarding general UX. Both are as important as eachother.

@zwiastunsw
Copy link
Contributor

Forms very often contain personal data. And they do not contain the cancel button. You don't want to send them, you just don't send them. Getting the Cancel button makes sense e.g. in the Backend of Joomla. You make settings for the options. But you don't want to save them and you want to leave the edit/new. The only way - the Close or Cancel button. In this case it makes sense.

@SharkyKZ
Copy link
Contributor

You can use browser's back button in backend too.

@zwiastunsw
Copy link
Contributor

@SharkyKZ : Do you want to propose to remove the Close/Cancel buttons from the backend? This is not a good idea. There these buttons are useful.
Imagine a page where there is only a registration form. Where, in your opinion, should the button / link Cancel lead?

@dgrammatiko
Copy link
Contributor

You can use browser's back button in backend too.

Leaving a form without saving or canceling in the backend leaves the edit item in the "checked in" state. In other words the item is locked. There is no way to just remove the cancel buttons in the backend without some serious architectural changes. Obviously people suggesting that don't really understand the fundamentals that Joomla is build upon...

@zwiastunsw
Copy link
Contributor

zwiastunsw commented Feb 24, 2019

@dgrammatiko : This is already known from Joomla 1.0 and even from Mambo. But maybe @SharkyKZ doesn't know.

@dgrammatiko
Copy link
Contributor

@SharkyKZ @zwiastunsw this is a good reference: #4773
Lots of valuable info there

@zwiastunsw
Copy link
Contributor

Thank you @dgrammatiko. But I do not propose to remove the Cancel buttons from the backend. I used their example to show when the Cancel button is needed. I didn't point to the important aspect you pointed out so as not to complicate this unnecessary discussion.

The gentlemen are trying to prove to me that the Cancel button on the registration form has some magical, even necessary functions. I explain that this button does nothing good. I explain that it causes confusion and why.

I explain that it is not needed for anything. I show examples that prove that it is unnecessary. No effect. I waste time discussing nothing.

I know a lot of such minor faults and accessibility errors in Joomla. But when I think that there will be a discussion on every PR as during the defense of scientific dissertation, I don't know if I have the time, willingness and strength to do so.

@dgrammatiko
Copy link
Contributor

@zwiastunsw I wouldn't commended in the first place but I see a lot of people suggesting/making PRs that are totally against the architecture of the system. I feel that these need to be turned down asap...
So my comment was only for the backend cancel button, I have no input/feedback on this actual PR so I'm muting myself

@SharkyKZ
Copy link
Contributor

I'm suggesting the button should clear form data like in any other form. Especially since this concerns personal data.

@zwiastunsw
Copy link
Contributor

zwiastunsw commented Feb 25, 2019

@SharkyKZ wrote:

I'm suggesting the button should clear form data like in any other form. Especially since this concerns personal data.

Really? I would be grateful for any references.
Here are some of mine:

(Ladies and) gentlemen, thank you all for this discussion. I really have learned a lot. I promise that this is my last 2 cents.

@ghost ghost added the J4 Issue label Apr 5, 2019
@ghost ghost added PR-4.0-dev and removed J4 Issue labels Apr 13, 2019
@ghost ghost changed the title [4.0][a11y] Remove button Cancel from Registration form [4.0] Remove button Cancel from Registration form Apr 19, 2019
@ghost ghost added the a11y Accessibility label Apr 19, 2019
@wilsonge wilsonge merged commit 642c0e8 into joomla:4.0-dev Jun 23, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 23, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 23, 2019
@zwiastunsw
Copy link
Contributor

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants