Uninstall error is thrown before uninstall preflight is executed

[Roeilab]

Steps to reproduce the issue

• Create an install script in line with Joomla documentation https://manual.joomla.org/docs/building-extensions/install-update/installation/install-process/
• Add the script to the manifest of your template
• Add two lines of code to the preflight function (line 1 and 4 below):
  use Joomla\CMS\Log\Log;
  public function preflight(string $type, InstallerAdapter $parent): bool
  {
  Log:add('preflight: ' . $type);
  return true;
  }
• Install your template, and set it to default (you can do that in postflight function or manually)
• Uninstall your template

Expected result

1. The line 'preflight: uninstall' is written to the log file
2. Joomla throws a warning: Template Uninstall: Can't remove default template

Actual result

1. Joomla throws a warning: Template Uninstall: Can't remove default template
2. The line 'preflight: uninstall' is NOT written to the log file

System information (as much as possible)

Additional comments

In the preflight function you should have the opportunity to set the cassiopeia template back to default, and then proceed with uninstall of your custom template. That way you avoid: Template Uninstall: Can't remove default template. That is how it worked on older versions of the install script. But now the uninstall aborts before preflight.

[alikon]

that's how it works since j4 didn't check on j3

imho we cannot delegate to the template developer to do this check

for me it's not a bug but expected behaviuor

[Roeilab]

I am sorry. It's a bug. I have reverted to legacy which works fine.

Suppose you want to remove a template at uninstall. Then you must first set a new default template during preflight before you can do the uninstall. But in the current version an error is thrown because you are trying to uninstall the default template. That error should not be thrown at preflight. In preflight you should be allowed to do all the actions necessary to prepare the uninstall. It works fine in legacy.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44511.}