Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

joomla-alert #332

Open
astridx opened this issue Jul 4, 2019 · 7 comments
Open

joomla-alert #332

astridx opened this issue Jul 4, 2019 · 7 comments

Comments

@astridx
Copy link
Contributor

astridx commented Jul 4, 2019

The header of joomla-alert has sometimes a space on the right side:
Menus  New Item   test   Administration(2)
New   test   Administration
Extensions  Discover   test   Administration

I would like to have it like this alert:
Edit   test   Administration

@brianteeman
Copy link
Contributor

I can not replicate this when using the latest css on the "edit-screen-approvement" branch using google chrome on windows

@astridx
Copy link
Contributor Author

astridx commented Jul 5, 2019

@brianteeman You are right. On chrome it is fine. But on firefox 67.0.4 (64 Bit) the problem persists. I am working on ubuntu 18.04.
But perhaps it is a firefox problem. I have the space in the newly created help button, too
PROJECT_NAME   Categories   test   Administration

@brianteeman
Copy link
Contributor

ok well its good to know that there is an issue to resolve and to test it we have to test with firefox

@brianteeman
Copy link
Contributor

@astridx I think I might no where the problem lies and why its ok on some and not on others. Can you test this.

  1. Create an article - dont enter a title and try save&close
    I believe this will give you an error message and there will be the white space on the right
  2. Create an article with a title and try save&close
    I believe this will take you back to the article manager with a success message and there will not be the white space.

If you can hopefuly confirm this then I know where the problem is

@astridx
Copy link
Contributor Author

astridx commented Jul 5, 2019

I can confirm this. And it was in the past the same. The green message is Ok. But the red error has the white space on the right side.

@brianteeman
Copy link
Contributor

ok so the problem is that the messages are generated by different code and there must be a slight difference. the success message is generated in messages.php and the other one in core.js

@bembelimen
Copy link
Contributor

Mhh, it does not happen in my regular resolution, but if I play arround with resizing (CTRL and [+]) it sometimes appears.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants