-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joomla 4 Admin menu #35
Comments
This is the first part of my comments. 1. Use the 2. Don't use ARIA menu semantics in navigation menus
3. Use semantics tag
4. ARIA markup
My proposal: Use this simple marking and then, if necessary, progressively improve it. |
I agree with all of this - just one part I don't understand
Do you mean all li elements or just the top level li elements eg Users, Menus, Content etc |
I am thinking of all the elements of |
reading this http://csskarma.com/blog/difference-rolepresentation-aria-hiddentrue/
will be seen in the DOM as
So I n ow understand why you chose role=presentation but shouldnt it be on the UL and not on every LI |
The 'ul' element says we have a list of elements. But the elements in this list are not 'li' but 'a'. Therefore, we remove the core role from the 'li' element, and not from the 'ul'. See source code in menu in the horizontal mega menu, the new website of the Accessiblility Initiative Thank you for the link ! :). |
I think it is not necessary to see the 'ul', Whether it is a list or not is not important or is it? But it should not make a difference for a11y. |
The benefit of the role being on the ul is that it will simplify and reduce the markup. |
@chmst You are right. This is not very important. But he is. The screen reader will announce for ex. Naivgation landmark list 6 items. |
This is the two part of my comments. Keyboard interaction Since the navigation menu is a set of links, the user can navigate through the menu items using the tab key. This is not a good solution, however, because users have to use the tab to access all menu items in order to get to the next active item on the page. In DHTML Style Guide Working Group was proposed the keyboard model, which was adapted in the WAI-ARIA Authoring Practices. Specifically, this guidance limits the role of the tab key to entering and existing the menu. In this model, once the menu has focus, the arrow keys, not tab, are used to navigate between top-level menu items.
About managing focus within components using a roving tabindex see WAI-ARIA practices. Note |
agreed |
Part two I guess is for me... |
Ok just out of curiosity why this is changing depending on the layout? I mean for visual impaired people the actual view of the page is less important than the arrow keys. Unless I'm missing something... |
It is not only people with visual impairments who use the keyboard. Also people who cannot use a mouse. |
Thank you @zwiastunsw I have updated the pen as per your suggestions (#35 (comment)) https://codepen.io/littlesnippets/pen/4d7312648363235a6b1c9ed9a8df64cf |
@DGT41 : I corrected description keyboard behavior after your comment. |
This is the third part of my comments. Screen readers interaction:
Use Javascript to dynamically change information about the expanded state submenu. Use |
the first three all seem to be done |
@brianteeman : Yes! |
So we have a new codepen https://codepen.io/dgt41/pen/jzLGaG with the (early) functionality in place.
Then we still have to patch correctly the close function and any other bugs that are still there. But this menu now is based on the code from W3C (we are allowed to use it, I checked with @brianteeman) so in theory we should be in the right track. |
Ciaran Walsh asks for tests and comments on the pen for new sidebar.
You can submit your comments immediately to
joomla/40-backend-template#365
or
If you want to discuss them first in the Joomla Accessibility Team, report them to this topic.
The text was updated successfully, but these errors were encountered: