Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filesearch): Implied extension @import statement #117 #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhnaeem
Copy link

@mhnaeem mhnaeem commented Nov 23, 2021

Fixing a bug where .less extension is not optional with some @import statements in certain directory
structures. This fix checks if the @import statement has an extension available, if an extension is
not provided we assume the default as .less.

fix #117

Fixes #

  • Did you add adequate test and make sure they pass by running npm run test
  • Did you add update docs in the README.md file?

Changes proposed in this pull request:

  • Instead of implying .less extension for @import statements make it the default

Steps to recreate issue:

Directory Structure:

.
├── a
│   ├── b
│   │   └── c
│   │       └── d.less
│   ├── e.less
│   └── index.less

Command:
npx less-watch-compiler ./a ./dist

index.less contains:

@import "./e";

every other file is empty

…ion throws ENOENT error

Fixing a bug where .less extension is not optional with some @import statements in certain directory
strcutures. This fix checks if the @import statement has an extension available, if an extension is
not provided we assume the default as .less, related to issue jonycheung#117

fix jonycheung#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.less extension in @import is not optional in watch mode under some file structures
2 participants